Wrong Documentation for Transfer

Michał Duszak staff commented 3 years ago

Those are the private members. User is supposed to be retrieving itemsToSend upon firing the onChange event.

---

Vasileios Valasidis commented 3 years ago

Sure , I agree with you ... But if you see my below comment the firing of onChange Event happens before changes ...

---

Michał Duszak staff commented 3 years ago

Thank you for your feedback. We will discuss changing it with the team.

---

  _handleSendToSource() {
    const itemsToSend = [];
    this._dataTarget.forEach((item) => {
      if (item.checked) {
        itemsToSend.push(item);
      }
    });
    !!!!!EventHandler.trigger(this._element, EVENT_ON_CHANGE, { sentItems: itemsToSend });
    !!!!!console.log('trigger change1');

    this._dataTarget = this._dataTarget.filter((item) => {
      const isNotCheck = !item.checked;
      item.checked = false;
      return isNotCheck;
    });
    this._dataSource = [...this._dataSource, ...itemsToSend];

    >>>>>EventHandler.trigger(this._element, EVENT_ON_CHANGE, { sentItems: itemsToSend });
    >>>>>console.log('trigger change1');
  }