scroll-spy service failing TSlint


Topic: scroll-spy service failing TSlint

Innovation Lab pro asked 6 years ago

The below error happened immediately after the recent MDB update. 
The build is failing due to this new component added.

Innovation Lab pro commented 6 years ago

The new version 7.3.0 is failing our tslint build with error messages above, we have currently solved the issue by specifying the previous working version in our package.json like below:

Next time the MDB team pushes breaking changes can they give the community a heads up to test before pushing, cause this brought down our build pipelines.


Mark Stevens pro commented 6 years ago

I'm getting the same issue with the new update.

 

ERROR in node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(10,20): error TS1005: ';' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(10,83): error TS1005: '(' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(11,27): error TS1005: ',' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(11,39): error TS1005: ';' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(11,45): error TS1109: Expression expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(12,32): error TS1005: ',' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(12,41): error TS1005: ';' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(12,47): error TS1109: Expression expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(13,34): error TS1005: ',' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(13,56): error TS1005: ',' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(13,65): error TS1005: ';' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(13,71): error TS1109: Expression expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(14,34): error TS1005: ',' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(14,56): error TS1005: ',' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(14,65): error TS1005: ';' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(14,71): error TS1109: Expression expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(15,29): error TS1005: ',' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(15,60): error TS1005: ';' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(15,66): error TS1109: Expression expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(16,34): error TS1005: ',' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(16,43): error TS1005: ';' expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(16,49): error TS1109: Expression expected.
node_modules/ng-uikit-pro-standard/ng-uikit-pro-standard/pro/scroll-spy/scroll-spy.service.d.ts(17,1): error TS1128: Declaration or statement expected.


if5.mdba commented 6 years ago

i got the same problem, please tell me how to fix it MDB Version: 6.3.0


For anyone wondering, the work around is to downgrade to the 7.2.0 release. For now that's how we avoided blocking productivity.


Damian Gemza staff answered 6 years ago

Guys,

Could you please provide me with the tslint config? I'm not unable to reproduce your problem, because for me linter is not throwing such errors. Without it and reproduction steps I won't be able to help you well.

Best Regards,

Damian


Sali Zumberi commented 6 years ago

Got the same problem and appreciate if you could solve it! It is very urgent, since we are releasing.


Innovation Lab pro answered 6 years ago

{ "rulesDirectory": [ "node_modules/codelyzer" ], "rules": { "arrow-return-shorthand": true, "callable-types": true, "class-name": true, "comment-format": [ true, "check-space" ], "curly": true, "deprecation": { "severity": "warn" }, "eofline": true, "forin": true, "import-blacklist": [ true, "rxjs/Rx" ], "import-spacing": true, "indent": [ true, "spaces" ], "interface-over-type-literal": true, "label-position": true, "max-line-length": [ true, 140 ], "member-access": false, "member-ordering": [ true, { "order": [ "static-field", "instance-field", "static-method", "instance-method" ] } ], "no-arg": true, "no-bitwise": true, "no-console": [ true, "debug", "info", "time", "timeEnd", "trace" ], "no-construct": true, "no-debugger": true, "no-duplicate-super": true, "no-empty": false, "no-empty-interface": true, "no-eval": true, "no-inferrable-types": [ true, "ignore-params" ], "no-misused-new": true, "no-non-null-assertion": true, "no-shadowed-variable": true, "no-string-literal": false, "no-string-throw": true, "no-switch-case-fall-through": true, "no-trailing-whitespace": true, "no-unnecessary-initializer": true, "no-unused-expression": true, "no-use-before-declare": true, "no-var-keyword": true, "object-literal-sort-keys": false, "one-line": [ true, "check-open-brace", "check-catch", "check-else", "check-whitespace" ], "prefer-const": true, "quotemark": [ true, "single" ], "radix": true, "semicolon": [ true, "always" ], "triple-equals": [ true, "allow-null-check" ], "typedef-whitespace": [ true, { "call-signature": "nospace", "index-signature": "nospace", "parameter": "nospace", "property-declaration": "nospace", "variable-declaration": "nospace" } ], "unified-signatures": true, "variable-name": false, "whitespace": [ true, "check-branch", "check-decl", "check-operator", "check-separator", "check-type" ], "no-output-on-prefix": true, "use-input-property-decorator": true, "use-output-property-decorator": true, "use-host-property-decorator": true, "no-input-rename": true, "no-output-rename": true, "use-life-cycle-interface": true, "use-pipe-transform-interface": true, "component-class-suffix": true, "directive-class-suffix": true } }


Damian Gemza staff answered 6 years ago

Dear Innovation Lab

Please provide me with reproduction steps - how I'll be able to reproduce your problem?

Do those errors comes after ng serve / npm start / ng build? Or after ng lint or some other command?

Could you please send me your application so I'll debug this problem? Here's my email address: d.gemza@mdbootstrap.com

We are unable to reproduce your problem in multiple scenarios.

Best Regards,

Damian


if5.mdba commented 6 years ago

their are comming after ng serve in my case


We're experiencing the exact same problem also.

Screenshot of Lint Errors


Arkadiusz Idzikowski staff answered 6 years ago

Did you install new version from gitlab or used .tgz file from the zip version? Can you try to remove node_modules and package-lock.json and reinstall with 'npm install' ?


Damian Gemza staff answered 6 years ago

Guys,

We have made some changes to the scroll-spy.service.ts file. The changes are available on the #dev branch of the ng-uikit-pro-standard repository.

If you have had a similar problem, please check if it continues.

Just change the line in the package.json file

"ng-uikit-pro-standard": "git+https://oauth2:<token>@git.mdbootstrap.com/mdb/angular/ng-uikit-pro-standard.git',

to

"ng-uikit-pro-standard": "git+https://oauth2:<token>@git.mdbootstrap.com/mdb/angular/ng-uikit-pro-standard.git#dev",

Consider that this is a development branch, and you should not use it on the production version of your application, because the changes made there are not yet fully tested.

In case of any problems I encourage you to contact me!

Best Regards,

Damian


Please insert min. 20 characters.

FREE CONSULTATION

Hire our experts to build a dedicated project. We'll analyze your business requirements, for free.

Status

Answered

Specification of the issue
  • User: Pro
  • Premium support: No
  • Technology: MDB Angular
  • MDB Version: 6.3.0
  • Device: Docker
  • Browser: Web and App
  • OS: Linux
  • Provided sample code: Yes
  • Provided link: No
Tags