modal.directive.ts - focusOtherModals - add null check

Topic: modal.directive.ts - focusOtherModals - add null check

Starceaker asked 7 years ago

In modal.directive.ts there is no null check on the parentElement. It would be cleaner to add a check here in my opinion.

protected focusOtherModal() {
 const otherOpenedModals = this._element.nativeElement.parentElement.querySelectorAll('.in[mdbModal]');
 if (!otherOpenedModals.length) {
 return;
 }
 this._renderer.invokeElementMethod(otherOpenedModals[otherOpenedModals.length - 1], 'focus');
 }

Add comment

Rafał Rogulski answered 7 years ago

1 1 Best answer

Hi, It's not needed because modal always show like a child of some element, it's the only situation when modal can't have a parent but this option is blocked. Regards

Add comment

Starceaker answered 7 years ago

1 0 Best answer

Hi Rafal The reason I mentioned this is because I received this error in my console while testing. That means it is possible to get this error. The modal is shown correctly but when closing it the console shows this error.

Rafał Rogulski commented 7 years ago

Hi That's mean is not a problem of parentElement, is mean it's problem with closing function. Please share her example code when this error showing we will look on this. Regards

Add comment

Write

Create snippet

FREE CONSULTATION

Hire our experts to build a dedicated project. We'll analyze your business requirements, for free.

Status

Answered

Specification of the issue

User: Free
Premium support: No
Technology: MDB Angular
MDB Version: -
Device: -
Browser: -
OS: -
Provided sample code: No
Provided link: No

About author

Starceaker

22Support score
6Questions 2Answers

0Snippets likes 0Snippets